Skip to content

fix(amazonq): not allow generate completion request go through if Q is editing (NEP) #7640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 11, 2025
Merged

fix(amazonq): not allow generate completion request go through if Q is editing (NEP) #7640

merged 2 commits into from
Jul 11, 2025

Conversation

@Will-ShaoHua
Copy link
Contributor

@Will-ShaoHua Will-ShaoHua commented Jul 10, 2025 •
edited
Loading

…

Problem

  • not allow generate completion request to go through if the edit is made by Q (only affecting NEP path)
  • add logging

Solution

  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Will-ShaoHua Will-ShaoHua requested a review from a team as a code owner July 10, 2025 23:37
@github-actions
Copy link

github-actions bot commented Jul 10, 2025

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@Will-ShaoHua Will-ShaoHua changed the title fix(amazonq): now allow generate completion request go through if Q is editing fix(amazonq): now allow generate completion request go through if Q is editing (NEP) Jul 10, 2025
atonaamz
atonaamz reviewed Jul 10, 2025
View reviewed changes
@Will-ShaoHua Will-ShaoHua changed the title fix(amazonq): now allow generate completion request go through if Q is editing (NEP) fix(amazonq): not allow generate completion request go through if Q is editing (NEP) Jul 11, 2025
@Will-ShaoHua Will-ShaoHua merged commit e0d2cbf into aws:master Jul 11, 2025
31 checks passed
@Will-ShaoHua Will-ShaoHua deleted the fix branch July 11, 2025 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@floralph floralph floralph approved these changes

@atonaamz atonaamz atonaamz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Will-ShaoHua @floralph @atonaamz